Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ActionList.Item conditional when FF is not enabled #4695

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Fix ActionList.Item conditional when FF is not enabled #4695

merged 2 commits into from
Jun 25, 2024

Conversation

TylerJDev
Copy link
Contributor

Changelog

Changed

Fixes conditional when primer_react_action_list_item_as_button feature flag is not enabled. This allows the forwarded ref to always be present, regardless of the FF being active or not. If the FF is inactive, it defaults to providing the <li> the ref. When the FF is active, applies it to either the <li> or the <button> based on the listSemantics const.

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jun 25, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 2a68038

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jun 25, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 91.01 KB (-0.11% 🔽)
packages/react/dist/browser.umd.js 91.37 KB (+0.03% 🔺)

@TylerJDev TylerJDev marked this pull request as ready for review June 25, 2024 12:16
@TylerJDev TylerJDev requested a review from a team as a code owner June 25, 2024 12:16
@TylerJDev TylerJDev requested a review from joshblack June 25, 2024 12:16
@joshblack joshblack added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit 9ee8ec9 Jun 25, 2024
30 checks passed
@joshblack joshblack deleted the fix-for-actionlist-semantics branch June 25, 2024 14:50
@primer primer bot mentioned this pull request Jun 21, 2024
Merged
@StemmlerSisters StemmlerSisters mentioned this pull request Jul 16, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jul 17, 2024
Open
@LLotme LLotme mentioned this pull request Jul 17, 2024
Open
@julitabarelkowska julitabarelkowska mentioned this pull request Jul 17, 2024
Open
@Canadatechmanufacturing Canadatechmanufacturing mentioned this pull request Jul 17, 2024
Open
This was referenced Jul 21, 2024
Open
Merged
This was referenced Aug 2, 2024
Open
Open
@snyk-io snyk-io bot mentioned this pull request Aug 13, 2024
Open
@WontonSam WontonSam mentioned this pull request Aug 16, 2024
Open
@OKEAMAH OKEAMAH mentioned this pull request Aug 17, 2024
Merged
@Mapuppy09 Mapuppy09 mentioned this pull request Aug 19, 2024
Merged
@sonukaloshiya sonukaloshiya mentioned this pull request Sep 4, 2024
Open
@AKJUS AKJUS mentioned this pull request Sep 13, 2024
Open
This was referenced Sep 15, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TylerJDev @joshblack